repartition: Correctly detect rootfs on loop device #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After resizing the main partition, we have the following logic to invoke
partprobe
if it is on a loop device:But empirically this block does not run on a fresh dual-boot installation: the kernel still believed the partition has its old size until I manually ran partprobe. As a result eos-firstboot fails to grow the main partition:
$using_loop is conditionally set as follows:
$orig_root_part is set as follows:
I ran this command once the system had booted and the output is:
This is not too surprising because eos-image-boot-generator has the following:
So the fix is to follow any symbolic links so we can inspect the real device path. Conveniently we already do this:
https://phabricator.endlessm.com/T35432